Skip to content

Minor fixes for the Unity Explorer #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 23, 2020
Merged

Conversation

citizenmatt
Copy link
Member

This PR fixes a few issues with the Unity Explorer:

  • Adds defensive code so that a failure to calculate the file system icon does not break the entire explorer view (RIDER-43038)
  • If a top level folder in /Packages has the same name as a package, but isn't the package, treat it as a normal file system folder. This can happen if a package with the same name is added with file:. This also correctly handles special folder icons under this folder and displaying project names (if the file: package is a reference into a folder under the top level file system folder. Yes, this can happen)
  • Limit the size of a folder's tooltip, if it has too many projects under it. E.g. Entities has 42 projects, and the tooltip listing them all is too big to fit on the screen properly. Now limited to 10 projects.

Avoids issues with folders in Packages that have the same name as a package, but aren't the package.

Fixed #1626
If a node is not the descendent of Assets or an actual package, treat it as a vanilla file system - no fancy icons, no project names
If the tooltip is too large, it won't show, so limit to 10 projects

Fixes #1628
@citizenmatt citizenmatt added this to the Rider 2020.1.1 milestone Apr 23, 2020
@citizenmatt citizenmatt self-assigned this Apr 23, 2020
@citizenmatt citizenmatt merged commit 9b45c1a into net201 Apr 23, 2020
@citizenmatt citizenmatt deleted the bug/unity-explorer-fixes branch April 23, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant