Comment out annotation on ExecuteAlways #1642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
[BaseTypeRequired(typeof(MonoBehaviour))]external annotation from theExecuteAlwaysattribute. This attribute can be applied to types deriving fromMonoBehaviour, but also fromUnity.Entities.SystemBase, although this is not currently documented in the docs forExecuteAlways.This PR comments out the annotation. It doesn't delete it so that we don't accidentally add it again. We don't have tests for annotations, and we especially don't have tests for absence of a warning.
See also #1639 about restoring this functionality but with a choice of base type between
MonoBehaviourandSystemBase/ComponentSystemBase.