Handle namespace suggestions for external packages #1689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works for packages that live at the root of a Unity solution, but doesn't work for packages external to the solution. External files are added to a project with a full path, and Rider will find the common ancestor folder and create a linked folder. This isn't included in namespace suggestions, and means we don't get a full folder structure for correct suggestions. The solution would be to add Link attributes to describe the correct location relative to the containing package root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands on #1677 to support correct namespace suggestions for packages that are outside of the normal Unity project structure and included via
file:references inPackages/manifest.json. It handles projects that live under the normal Unity project folder location (but not underAssetsorPackages) and also projects outside of the solution structure completely.To recap, the idea is this:
Packages,Library/PackageCacheor anywhere else on disk, and when underLibrary/PackageCache, the name can contain ID and version, but won't have this name when cloned from GitHub)Assets, and those folder names should affect the namespace. Moving a package will not affect this.Scripts,Runtime,Scripts/RuntimeandRuntime/Scripts.