Skip to content

Support new UnityEditor module split #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 1, 2020
Merged

Support new UnityEditor module split #1724

merged 4 commits into from
Jul 1, 2020

Conversation

citizenmatt
Copy link
Member

Unity 2020.2 is splitting UnityEditor.dll into modules. This PR:

  • Add external annotations for UnityEngine.CoreModule.dll
  • Fall back to correct UnityEngine module when loading types via reflection
  • Include UnityEngine.CoreModule when checking for Unity references

@citizenmatt citizenmatt added this to the Rider 2020.2 milestone Jul 1, 2020
@citizenmatt citizenmatt requested a review from van800 July 1, 2020 00:35
@citizenmatt citizenmatt self-assigned this Jul 1, 2020
@citizenmatt citizenmatt merged commit dd7a057 into net202 Jul 1, 2020
@citizenmatt citizenmatt deleted the feature/editor-modules branch July 1, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@van800 van800 van800 approved these changes

Assignees

@citizenmatt citizenmatt

Labels
None yet
Projects
None yet
Milestone
Rider 2020.2
Development

Successfully merging this pull request may close these issues.
2 participants
@citizenmatt @van800