Skip to content

Pre commit hook, which was checking unsaved scenes, is not checking also other GameObjects states, like ScriptableObjects #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

Pre commit hook, which was checking unsaved scenes, is not checking also other GameObjects states, like ScriptableObjects #2338

wants to merge 19 commits into from

Conversation

van800
Copy link
Member

@van800 van800 commented Jul 18, 2022 •
edited
Loading

Pre commit hook, which was checking unsaved scenes, is not checking also other GameObjects states, like ScriptableObjects.

@van800 van800 added the WIP Work in progress. Do not merge! label Jul 18, 2022
@van800 van800 requested a review from citizenmatt July 18, 2022 14:29
@van800 van800 self-assigned this Jul 18, 2022
@van800 van800 changed the base branch from net222 to net223 July 18, 2022 14:29
@van800 van800 removed the WIP Work in progress. Do not merge! label Jul 19, 2022
@van800 van800 changed the title Net223 rider 63673 pre commit hook persistent game object together with dirty Scenes Pre commit hook, which was checking unsaved scenes, is not checking also other GameObjects states, like ScriptableObjects Jul 19, 2022
citizenmatt
citizenmatt reviewed Jul 20, 2022
View reviewed changes
@van800 van800 requested a review from citizenmatt July 21, 2022 07:25
citizenmatt
citizenmatt approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@citizenmatt citizenmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@van800
Copy link
Member Author

van800 commented Aug 1, 2022

merged https://buildserver.labs.intellij.net/buildConfiguration/DotNetDiv_Wave223_TriggerPullRequestMergeIntoNet223/201463110?buildTab=changes&showFiles=false&expandRevisionsSection=true

@van800 van800 closed this Aug 1, 2022
@citizenmatt citizenmatt added this to the Rider 2022.3 milestone Aug 17, 2022
@citizenmatt citizenmatt deleted the net223-RIDER-63673_pre-commit_hook_persistent_GO branch August 17, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizenmatt citizenmatt citizenmatt approved these changes

Assignees

@van800 van800

Labels
None yet
Projects
None yet
Milestone
Rider 2022.3
Development

Successfully merging this pull request may close these issues.
2 participants
@van800 @citizenmatt