-
Notifications
You must be signed in to change notification settings - Fork 0
Create devcontainer.json #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new devcontainer.json file to the project. The file specifies the use of the 'mcr.microsoft.com/devcontainers/universal:2' Docker image and initializes an empty 'features' object. This setup is intended to standardize the development environment using a container. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JoftheV - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding relevant features to the 'features' object to enhance the development environment.
- Evaluate if a more specific or lightweight image would be more appropriate for your project's needs, instead of the universal image.
- For future PRs, please provide a more detailed description explaining the rationale behind the changes and their intended impact.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit all suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finish
Create a container.json
Summary by Sourcery
This pull request introduces a devcontainer.json file to set up a development container environment using the universal image from Microsoft. This change aims to standardize the development environment for the project.