Skip to content

Create devcontainer.json #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2024

Conversation

JoftheV
Copy link
Owner

@JoftheV JoftheV commented Jul 26, 2024

Create a container.json

Summary by Sourcery

This pull request introduces a devcontainer.json file to set up a development container environment using the universal image from Microsoft. This change aims to standardize the development environment for the project.

  • Build:
    • Added a devcontainer.json file to define a development container using the universal image from Microsoft.

Copy link

sourcery-ai bot commented Jul 26, 2024

Reviewer's Guide by Sourcery

This pull request introduces a new devcontainer.json file to the project. The file specifies the use of the 'mcr.microsoft.com/devcontainers/universal:2' Docker image and initializes an empty 'features' object. This setup is intended to standardize the development environment using a container.

File-Level Changes

Files Changes
.devcontainer/devcontainer.json Added a new devcontainer.json file to set up a development container using the universal image from Microsoft.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JoftheV - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding relevant features to the 'features' object to enhance the development environment.
  • Evaluate if a more specific or lightweight image would be more appropriate for your project's needs, instead of the universal image.
  • For future PRs, please provide a more detailed description explaining the rationale behind the changes and their intended impact.
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

JoftheV and others added 2 commits July 26, 2024 19:23
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Copy link
Owner Author

@JoftheV JoftheV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit

@JoftheV JoftheV merged commit 0cbee87 into master Jul 27, 2024
1 of 4 checks passed
Copy link
Owner Author

@JoftheV JoftheV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit all suggestions

Copy link
Owner Author

@JoftheV JoftheV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant