Add support for exceptions ports + aarch64#8
Conversation
|
Sorry I don't have a MacOS machine with x64 around, so I can't debug these tests, especially as they seem to be failing on a C file that's generated by the |
|
We have two errors: Both are type-mismatch errors, On x64 xcode 11.7.0-13.1.0, the |
|
Friendly-ping @bnjbvr, do you have some time to address the above failure? |
|
Yep, I could get back to it but likely not before July. I don't have any x86 mac hardware to use for testing so this makes it a bit frustrating and inefficient to try, but I can play along with CI I guess. In any case, anyone can feel free to take over this PR and finish the remaining bits if they'd like 🙂 |
|
Alright, this passes tests on CI but not on a local aarch64 mac machine; investigating. |
|
Tests now passing on my aarch64 darwin machine 🥳 |
JohnTitor
left a comment
There was a problem hiding this comment.
Sorry for the delay, thanks!
This adds enough support for bytecodealliance/wasmtime#2632 to not add its own bindings, plus it brings up support for Apple Silicon (aarch64) by tweaking/adding a few data structures.
One note for reviewers: yes it's weird, but the count() implementations are indeed different when I look at my local mach header files. They are reflected as such in this PR.