Replace sed with awk

[Pjort]

Not sure what has caused it, might be the ubuntu 20.04. But I keep getting follow error when starting the docker:

sed: -e expression #1, char 123: unterminated s' command
sed: -e expression #1, char 133: unterminated s' command

I tried altering the delimiter, but I was not able to find a solution that used sed. But I got it working with awk.

[JonasVautherin]

Isn't it because QGC_PARAM and API_PARAM are multi-line strings? Pretty sure that the output of ahostsv4 is multiple lines, and we only want one.

[JonasVautherin]

@Pjort: can you try with this instead? 95ecb06

I already pushed it to master, since the latest image on docker hub is broken anyway. You are a co-author on the commit 👍. Would be nice if you could tell me if it works for you, and on which platform you tried (Linux, macOS, Windows? Docker, Podman?)

[Pjort]

@Pjort: can you try with this instead? 95ecb06

I already pushed it to master, since the latest image on docker hub is broken anyway. You are a co-author on the commit 👍. Would be nice if you could tell me if it works for you, and on which platform you tried (Linux, macOS, Windows? Docker, Podman?)

I have tested the master on docker hub now. On windows 11, using both docker desktop 4.41.1 (the problematic version) and podman.

It definately solved the issue for docker desktop, it works now without having to provide ips.

Podman, on windows atleast, still needs the ip of the host machine. And if with that the connection doesn't seem right, QGroundControl can make a connection, but can't download params, nor arm etc.

[Pjort]

Also I just noticed, the difference in size between 1.15.4 and master is 1.5gb. Maybe a slim version of ubuntu:20.04 should be used?

[JonasVautherin]

It definately solved the issue for docker desktop

🎉

Podman, on windows atleast, still needs the ip of the host machine.

Are you running Podman in rootless mode?

[Pjort]

It definately solved the issue for docker desktop

🎉

Podman, on windows atleast, still needs the ip of the host machine.

Are you running Podman in rootless mode?

I tried running Podman machine both --rootful and --rootfull=false. Same problem.

[JonasVautherin]

I have issues with Podman too (I tried only rootless). If I point it to another device on the LAN (say 192.168.1.12) it just doesn't work. Also I have realised that whatever I ping "seems to work", as if it was intercepted. Like I can ping 222.111.222.111 and it will look like it's working, for some reason 🤔.

Anyway I'll close this, and we can open a new issue for podman support if that's a need 👍.

Thanks for the help with this! 🚀