Enhance Dockerfile with metadata support and permissions #59
Conversation
kaeladair
commented
May 22, 2025
kaeladair
commented
- Added environment variables for PX4 metadata and board configuration.
- Created a metadata directory with appropriate permissions during the build process.
- Added environment variables for PX4 metadata and board configuration. - Created a metadata directory with appropriate permissions during the build process.
|
@JonasVautherin @julianoes MAVSDK Events interface wasn't able to fetch metadata from my SITL setup when using this, these changes fixed it on my end |
| RUN mkdir -p ${FIRMWARE_DIR}/build/px4_sitl_default/component_metadata && \ | ||
| chmod -R 777 ${FIRMWARE_DIR}/build/px4_sitl_default/component_metadata && \ | ||
| cd ${FIRMWARE_DIR} && \ | ||
| DONT_RUN=1 PX4_METADATA=1 CONFIG_BOARD_CONSTRAINED_FLASH=n make px4_sitl_default |
There was a problem hiding this comment.
Do we have to run that after the RUN of line 69? Or could we merge both RUNs?
There was a problem hiding this comment.
Would you mind trying? That would simplify the code 😊
|
I tried to test this and for me it works fine without these changes, just by building from master. Edit: I also tried latest like this |
|
Hm yeah I found the same to be true, don't think this is needed, just trying to figure out why the one before the latest doesn't work |
|
Oh even better! So we can close this? |
3 participants
