-
Notifications
You must be signed in to change notification settings - Fork 31
React v18 update #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React v18 update #294
Conversation
This looks good, but the only issue is the override in the I get that the changes needed are in Other than that, yeah, this seems fine to me. |
Yes, the override will be dropped and replaced by package set update before merge. Converted to draft PR to make clear this won't be merged in its current state. |
Sounds good! |
Looks like we only need to update the |
Aaaaand... update all the other react examples. Currently only one of them is modified. This can be another pullrequest though, since the api is deprecated, but not broken and will still work. The latest package set doesn't have the react update. With the next package set, we'll have it. |
Updated the package set. I would be fine with merging this PR as is:
The current and expected state of the non-updated react examples is to see these warnings. They're exactly what this PR solved, but only for "HelloReactHooks". The examples with warnings still work. |
Thanks! |
This is the suggested update path to react v18:
#root
(solves Solves Compact and warning-free React recipes #198)createRoot
as recommented in react v18app
), for consistency across examples.If this change is good to go, I can roll it out to all
ReactHooks
examples.