Skip to content

Add isconstantfun and check while converting to ConstantSpace #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Feb 3, 2024

After this, coefficients for non-constant Funs can't be evaluated in a ConstantSpace.
The following works on master, but will be disallowed:

julia> coefficients(Fun(Chebyshev(0..1)), ConstantSpace(0..1))
2-element Vector{Float64}:
  0.5
 Inf

The newly added function isconstantfun is intended to be extended by downstream packages to provide more efficient implementations.

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (768625d) 75.07% compared to head (3963a6b) 75.19%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
+ Coverage   75.07%   75.19%   +0.11%     
==========================================
  Files          80       79       -1     
  Lines        8439     8443       +4     
==========================================
+ Hits         6336     6349      +13     
+ Misses       2103     2094       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 023b1a4 into JuliaApproximation:master Feb 3, 2024
@jishnub jishnub deleted the isconstfun branch February 3, 2024 11:38
@jishnub jishnub mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant