Skip to content

All the docs! #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 8, 2025
Merged

All the docs! #84

merged 15 commits into from
May 8, 2025

Conversation

icweaver
Copy link
Member

@icweaver icweaver commented May 6, 2025

Brief summary

In this PR, our comparison page and ecosystem page are now both created automatically and in sync with each other from a single source of truth, src/JuliaAstroDocs.jl. No more manually editing raw html by hand

The impl is just a dumb for-loop, so things can def be cleaned up more. Luckily though, this is just an implementation detail that can be punted to future PRs. The main entry point for contributors in src/JuliaAstroDocs.jl remains unchanged

Brief summary

In this PR, our comparison page and ecosystem page are now both created automatically and in sync with each other from a single source of truth, src/JuliaAstroDocs.jl. No more manually editing raw html by hand

The impl is just a dumb for-loop, so things can def be cleaned up more. Luckily though, this is just an implementation detail that can be punted to future PRs. The main entry point for contributors in src/JuliaAstroDocs.jl remains unchanged

Broad notes

  • Cleaned up the organization for AstroImages.jl and Photometry.jl a bit
  • Added more packages to ecosystem page to come up to parity with the comparison page
  • Split back out Abhro's merging of the spectra packages (e7f732a) just to make the loop logic easier. This could be put back in a future PR if we really want tho

Future PRs

  • General is starting to get pretty long now (whoo!) Maybe it's time to start reaching for the M E G A DropdownNav

To-do

  • Update tests

@icweaver icweaver marked this pull request as ready for review May 6, 2025 06:41
@icweaver icweaver merged commit a4d6f4d into JuliaAstro:source May 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant