Skip to content

Run gcscrub after warmup and remove unnecessary gc run for first sample #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willow-ahrens merged 3 commits into from
May 3, 2024
+3 −4
Merged

Run gcscrub after warmup and remove unnecessary gc run for first sample #367

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f88ebf2
Run gcscrub after warmup and remove unnecessary gc run for first sample
Zentrik May 2, 2024
97fcb07
Merge branch 'master' into patch-4
willow-ahrens May 3, 2024
b366a5f
Don't count warmup time for seconds to run benchmarking
Zentrik May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/execution.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,14 @@ end
function _run(b::Benchmark, p::Parameters; verbose=false, pad="", warmup=true, kwargs...)
params = Parameters(p; kwargs...)
@assert params.seconds > 0.0 "time limit must be greater than 0.0"
params.gctrial && gcscrub()
start_time = Base.time()
trial = Trial(params)
warmup_start_time = Base.time()
if warmup
b.samplefunc(b.quote_vals, Parameters(params; evals=1)) #warmup sample
end
params.gcsample && gcscrub()
warmup_time = Base.time() - warmup_start_time
trial = Trial(params)
params.gctrial && gcscrub()
start_time = Base.time() - warmup_time
Comment thread
Zentrik marked this conversation as resolved.
Outdated
s = b.samplefunc(b.quote_vals, params)
push!(trial, s[1:(end - 1)]...)
return_val = s[end]
Expand Down