Fix compilation and interpolation memory leaks#385
Merged
Conversation
vchuravy
approved these changes
Jan 7, 2025
vchuravy
left a comment
Member
There was a problem hiding this comment.
Looks fine, but I must admit I don't understand this code anymore.
Collaborator
Author
|
It's confusing to need the function to always run at global scope, and requires some involved metaprogramming to get that right. Hopefully this is one step closer to a correct approach which is still backwards-compatible with the older versions. |
Contributor
|
This is remarkably clever. Brava! |
LilithHafner
added a commit
to LilithHafner/Chairmarks.jl
that referenced
this pull request
Feb 15, 2025
Because @willow-ahrens fixed this leak in a non-breaking release of BenchmarkTools so it was apparently not unavoidable. (JuliaCI/BenchmarkTools.jl#385)
LilithHafner
added a commit
to LilithHafner/Chairmarks.jl
that referenced
this pull request
Feb 15, 2025
Because @willow-ahrens fixed this leak in a non-breaking release of BenchmarkTools so it was apparently not unavoidable. (JuliaCI/BenchmarkTools.jl#385)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #339. Fixes a memory leak in interpolated variables from
setupandteardown, continuing what was started in #265. Additionally, adds a cache of already-compiled sampler functions, so that wrapping a@benchmarkin a for-loop doesn't compile separate functions each iteration.Here's an example:
Setup
Main Branch
After Fixing Setup Leaks
After Fixing Redundant Compilation