Fix CI on nightly #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 22, 2022 10:57
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 97.84% 96.40% -1.44%
==========================================
Files 1 1
Lines 325 334 +9
==========================================
+ Hits 318 322 +4
- Misses 7 12 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The errors were due to changes in internals in Base/sort.jl which gave 1) rise to a method ambiguity (fixed by narrowing the type signature of
sort!(::RadixSort)) and 2) cause the floating point optimizations to take place even when alg=RadixSort (fixed by defininguint_mapping(::Sort.Float.Left, ::IEEEFloat))