FemtoCleaner for julia 1

[aminya]

Needs help.

[XVilka]

1.19s$ julia -e ' Pkg.clone("https://github.com/aminya/Deprecations.jl"); Pkg.clone(pwd()); Pkg.build("FemtoCleaner"); Pkg.checkout("AbstractTrees"); import JSON; for (pkg, version) in JSON.parse(readstring("dependencies.json")) LibGit2.with(LibGit2.GitRepo, Pkg.dir(pkg)) do deprepo LibGit2.checkout!(deprepo, version) end; Pkg.pin(pkg); end; Pkg.resolve(); Pkg.test("FemtoCleaner"; coverage=true) '

ERROR: UndefVarError: Pkg not defined

Stacktrace:

 [1] top-level scope at none:0

The command "julia -e ' Pkg.clone("https://github.com/aminya/Deprecations.jl"); Pkg.clone(pwd()); Pkg.build("FemtoCleaner"); Pkg.checkout("AbstractTrees"); import JSON; for (pkg, version) in JSON.parse(readstring("dependencies.json")) LibGit2.with(LibGit2.GitRepo, Pkg.dir(pkg)) do deprepo LibGit2.checkout!(deprepo, version) end; Pkg.pin(pkg); end; Pkg.resolve(); Pkg.test("FemtoCleaner"; coverage=true) '" exited with 1.

Failed Travis

[aminya]

I abandoned updating this. It is beyond my experience with Julia. Someone should know old syntaxes and then update this. The developers themselves should update this

[logankilpatrick]

So the issue is that the syntax of the repo itself needs to be updated?

[aminya]

Yes the FemtoCleaner/Deprecations should be written in Julia 1. Also, we need to address changes after Julia 0.6.4 in Deprecations so FemtoCleaner uses them.
If we could do this, there are numerous packages to revive (https://discourse.julialang.org/t/ann-plans-for-removing-packages-that-do-not-yet-support-1-0-from-the-general-registry/28003 )

[logankilpatrick]

Can FemtoCleaner clean itself?! Best, Logan Kilpatrick

…

On Sep 12, 2019, at 9:42 PM, Amin Yahyaabadi ***@***.***> wrote: Yes the FemtoCleaner/Deprecations should be written in Julia 1. Also, we need to address changes after Julia 0.6.4 in Deprecations so FemtoCleaner uses them. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[aminya]

Can FemtoCleaner clean itself?! Best, Logan Kilpatrick
…
On Sep 12, 2019, at 9:42 PM, Amin Yahyaabadi @.***> wrote: Yes the FemtoCleaner/Deprecations should be written in Julia 1. Also, we need to address changes after Julia 0.6.4 in Deprecations so FemtoCleaner uses them. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

I have already done this in this PR. But that is not enough because Deprecations doesn't address the changes after Julia 0.6.4

[XVilka]

Too bad actual repository owners keep silence on this issue.

[logankilpatrick]

My guess is that it would have been updated, but most repos don’t need this anymore so there’s not enough demand to make it worth it. The maintainers have many other things they need to help with that are likely more important than this repo. Best, Logan Kilpatrick

…

On Oct 17, 2019, at 12:25 AM, Anton Kochkov ***@***.***> wrote:  Too bad actual repository owners keep silence on this issue. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[aminya]

If anyone wants to work on this, they responded to my old issue:

julia-vscode/CSTParser.jl#102

I am trying to upgrade Deprecations.jl for FemtoCleaner. In Deprecations code CSTParser.BinarySyntaxOpCall is used a lot like here.

I found its definition here.

What has happened to this in recent versions?

Answer:

Dedicated expression datatypes (e.g. BinarySyntaxOpCall, UnaryOpCall, etc.) were replaced by a single expression type (EXPR). The 'type' of expressions are now stored in the .typ field which should be accessed using CSTParser.typof(x::EXPR).

The change was made for increasing parsing speed.