Skip to content

Add CI workflow #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Add CI workflow #19

merged 3 commits into from
Oct 8, 2021

Conversation

sethaxen
Copy link
Member

@sethaxen sethaxen commented Oct 4, 2021

This PR adds a CI workflow to catch cases like #18

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@c974d02). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   79.53%           
=========================================
  Files             ?        1           
  Lines             ?      342           
  Branches          ?        0           
=========================================
  Hits              ?      272           
  Misses            ?       70           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c974d02...79ece30. Read the comment docs.

@mohamed82008
Copy link
Member

Thanks @sethaxen! I wonder if it's worth supporting Julia 1.0 at this point. Do you know anyone who still uses it?

@odow
Copy link

odow commented Oct 7, 2021

Do you know anyone who still uses it?

Just an FYI with a view to JuMP potentially using this package at some point:

JuMP will always support the latest LTS release. Even if 1.6 is announced as the new LTS, we'll probably keep support for 1.0 around for a while longer.

It's more a case of "why shouldn't you support 1.0," e.g., if JLL or threading changes are mission critical for the package it makes sense to drop 1.0.

@ChrisRackauckas
Copy link
Member

v1.6 is already the slated LTS according to JuliaLang/www.julialang.org#1354, so I just wouldn't put the time in for v1.0

@mohamed82008
Copy link
Member

It's ok I will do the (little) extra work for JuMP :)

@mohamed82008
Copy link
Member

I will merge this for now and open another issue to track 1.0 support.

@mohamed82008 mohamed82008 merged commit 3eb3fd1 into JuliaDiff:master Oct 8, 2021
@mohamed82008
Copy link
Member

Well there is already an issue :)

@sethaxen sethaxen deleted the add_ci branch October 8, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants