Skip to content

Implemented new GeoInterface. #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 23, 2022
Merged

Implemented new GeoInterface. #112

merged 4 commits into from
Jun 23, 2022

Conversation

evetion
Copy link
Member

@evetion evetion commented Jun 6, 2022 •
edited
Loading

Implemented the base requirements for GeoInterface. A later PR will include all operations, crs, extents etc.

@evetion evetion requested a review from visr June 6, 2022 10:22
@evetion evetion mentioned this pull request Jun 6, 2022
Closed
12 tasks
@visr visr force-pushed the feat/geointerface branch from 410029e to 99f5ac7 Compare June 6, 2022 20:27
visr
visr approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I rebased and squashed a bit to clean up and update the diff, and removing the prefixes GeoInterface. before the traits, and reformatting after that.

I guess it's best to wait tagging v0.7 until the other PRs you mention are also in right?

@evetion evetion merged commit dfd332c into master Jun 23, 2022
@evetion evetion deleted the feat/geointerface branch June 23, 2022 07:26
@evetion evetion mentioned this pull request Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evetion @visr