Skip to content

Add benchmark action #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025
Merged

Add benchmark action #1221

merged 4 commits into from
Jun 27, 2025

Conversation

juliohm
Copy link
Member

@juliohm juliohm commented Jun 27, 2025

Fix #1200

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (eef36f1) to head (5183a5d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1221   +/-   ##
=======================================
  Coverage   88.02%   88.02%           
=======================================
  Files         196      196           
  Lines        6179     6179           
=======================================
  Hits         5439     5439           
  Misses        740      740           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliohm juliohm requested a review from JoshuaLampert June 27, 2025 00:57
@juliohm
Copy link
Member Author

juliohm commented Jun 27, 2025

@JoshuaLampert I believe that this is all that is needed to get the benchmarks in place? We need to merge this PR in order to see the bot comments in future PRs?

Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Yes, this PR needs to be merged first to get the comments (this is due to the pull_request_target instead of pull_request).

@juliohm
Copy link
Member Author

juliohm commented Jun 27, 2025

That is awesome @JoshuaLampert , thank you for the suggestion. Makes total sense to test against the benchmark script of the PR.

@juliohm juliohm merged commit a8b84c9 into master Jun 27, 2025
15 of 16 checks passed
@juliohm juliohm deleted the airspeed-action branch June 27, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use AirspeedVelocity.jl as GitHub Action
2 participants