-
Notifications
You must be signed in to change notification settings - Fork 93
Add benchmark action #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark action #1221
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1221 +/- ##
=======================================
Coverage 88.02% 88.02%
=======================================
Files 196 196
Lines 6179 6179
=======================================
Hits 5439 5439
Misses 740 740 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@JoshuaLampert I believe that this is all that is needed to get the benchmarks in place? We need to merge this PR in order to see the bot comments in future PRs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! Yes, this PR needs to be merged first to get the comments (this is due to the pull_request_target
instead of pull_request
).
Co-authored-by: Joshua Lampert <[email protected]>
That is awesome @JoshuaLampert , thank you for the suggestion. Makes total sense to test against the benchmark script of the PR. |
Fix #1200