Skip to content

Miscellaneous improvements #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 9, 2025
Merged

Miscellaneous improvements #1228

merged 17 commits into from
Jul 9, 2025

Conversation

juliohm
Copy link
Member

@juliohm juliohm commented Jul 8, 2025

Miscellaneous improvements to source code related to primitives.

Copy link
Contributor

github-actions bot commented Jul 8, 2025

Benchmark Results (Julia vlts)

Time benchmarks
master 25f8f93... master / 25f8f93...
clipping/SutherlandHodgman 3.68 ± 0.36 μs 3.71 ± 0.18 μs 0.992 ± 0.11
discretization/simplexify 27.2 ± 1.2 ms 26.4 ± 1.5 ms 1.03 ± 0.072
sideof/ring/large 6.53 ± 0.01 μs 6.53 ± 0.01 μs 1 ± 0.0022
sideof/ring/small 0.05 ± 0.001 μs 0.06 ± 0.01 μs 0.833 ± 0.14
winding/mesh 0.0429 ± 0.0012 s 0.0421 ± 0.0016 s 1.02 ± 0.049
time_to_load 1.44 ± 0.007 s 1.45 ± 0.0062 s 0.998 ± 0.0065
Memory benchmarks
master 25f8f93... master / 25f8f93...
clipping/SutherlandHodgman 0.053 k allocs: 4.97 kB 0.053 k allocs: 4.97 kB 1
discretization/simplexify 0.226 M allocs: 21.8 MB 0.226 M allocs: 21.8 MB 1
sideof/ring/large 0 allocs: 0 B 0 allocs: 0 B
sideof/ring/small 0 allocs: 0 B 0 allocs: 0 B
winding/mesh 0.231 M allocs: 23 MB 0.231 M allocs: 23 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Copy link
Contributor

github-actions bot commented Jul 8, 2025

Benchmark Results (Julia v1)

Time benchmarks
master 25f8f93... master / 25f8f93...
clipping/SutherlandHodgman 3.34 ± 0.18 μs 3.35 ± 0.21 μs 0.997 ± 0.083
discretization/simplexify 25.2 ± 3.5 ms 25.1 ± 3.4 ms 1 ± 0.19
sideof/ring/large 6.78 ± 0.099 μs 6.84 ± 0.06 μs 0.991 ± 0.017
sideof/ring/small 0.06 ± 0.01 μs 0.06 ± 0 μs 1 ± 0.17
winding/mesh 0.0423 ± 0.0029 s 0.0426 ± 0.0026 s 0.993 ± 0.09
time_to_load 1.53 ± 0.019 s 1.51 ± 0.0035 s 1.01 ± 0.013
Memory benchmarks
master 25f8f93... master / 25f8f93...
clipping/SutherlandHodgman 0.053 k allocs: 4.83 kB 0.053 k allocs: 4.83 kB 1
discretization/simplexify 0.324 M allocs: 21.8 MB 0.324 M allocs: 21.8 MB 1
sideof/ring/large 0 allocs: 0 B 0 allocs: 0 B
sideof/ring/small 0 allocs: 0 B 0 allocs: 0 B
winding/mesh 0.329 M allocs: 22.9 MB 0.329 M allocs: 22.9 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.94%. Comparing base (d2f5fd7) to head (25f8f93).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/pointification.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
- Coverage   87.96%   87.94%   -0.03%     
==========================================
  Files         196      196              
  Lines        6225     6222       -3     
==========================================
- Hits         5476     5472       -4     
- Misses        749      750       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliohm juliohm changed the title Introduce CylinderWall and ConeWall primitives Miscellaneous improvements Jul 9, 2025
@juliohm juliohm marked this pull request as ready for review July 9, 2025 18:07
@juliohm juliohm merged commit 04d0330 into master Jul 9, 2025
30 of 31 checks passed
@juliohm juliohm deleted the issue-1107 branch July 9, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant