Skip to content

Conversation

@gdalle
Copy link
Member

@gdalle gdalle commented Apr 6, 2023

fix #8 and #9 by

  • specifying that self-loops are not supported
  • specifying that constructors from edge lists should avoid duplicate edges

@gdalle gdalle requested a review from matbesancon April 6, 2023 07:34
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #42 (344b7ee) into master (d995ffd) will not change coverage.
The diff coverage is n/a.

❗ Current head 344b7ee differs from pull request most recent head 8788527. Consider uploading reports for the commit 8788527 to get more accurate results

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files           9        9           
  Lines         445      445           
=======================================
  Hits          422      422           
  Misses         23       23           
Impacted Files Coverage Δ
src/SimpleWeightedGraphs.jl 100.00% <ø> (ø)
src/simpleweighteddigraph.jl 96.47% <ø> (ø)
src/simpleweightedgraph.jl 93.39% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gdalle gdalle removed the request for review from matbesancon April 6, 2023 10:38
@gdalle gdalle merged commit 289d729 into master Apr 6, 2023
@gdalle gdalle deleted the docs_precisions branch April 6, 2023 10:45
@simonschoelly
Copy link
Member

Since when are self-loops not supported? There might be some issues, but apart from, we have always tried to support them. I don't think we can simply add to the documentation that they are now not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Port] Inconsistent adjacency matrix for weighted and unweighted graphs

3 participants