Rename context API methods as internal functions #4161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/private_context_functions
branch
6 times, most recently
from
fe50cd4 to
8389e06
Compare
IanButterworth
force-pushed
the
ib/private_context_functions
branch
3 times, most recently
from
9cb24db to
1416f46
Compare
|
Makes sense to me - we should make it easy to notice when a generic function is private or internal. |
IanButterworth
force-pushed
the
ib/private_context_functions
branch
3 times, most recently
from
9a209a7 to
4571d6a
Compare
IanButterworth
force-pushed
the
ib/private_context_functions
branch
from
4571d6a to
b05dd87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Pkg.add(ctx::Context.....methods are internal methods that require preconditioning the input args using internal functionsPkg.jl/src/API.jl
Lines 162 to 163 in c54ee59
This renames those methods to underscore versions to make it clearer that they're internal.
BinaryBuilderBase is known to use the
Pkg.add(ctxmethod and during development saw the confusinglengtherrors #4160 that you get if you don't precondition the input, which added to the impression that Pkg was broken. @giordano and I have talked about moving that to the public way of controlling the julia version via thejulia_versionkwarg, which has better test coverage now and should be in better shape now since #4151 and #4156Ecosystem fixes:
julia_versionPkg.addkwarg rather than specifying it through ctx JuliaPackaging/BinaryBuilderBase.jl#416