word choice improvements

[JeffreySarnoff]

consider each [group] of the rows

suggestion	to replace		source
namesfrom	names		@nickrobinson251
phase	angle		@ExpandingMan
streampos	position		@JeffreySarnoff
diagindex	diagind		@imciner2
nextindex	nextind		@jakobnissen
previndex	prevind		@zdroid
thisindex	thisind		@jakobnissen
valuetype	valtype		@quinnj
stepsize	step		@CameronBieganek
joinstring	join		@iamed2
VarArg	Vararg		various

select one from each alternative set

alternatives	suggestion	to replace		source
{a1,a2), b				@musm
a1	countzeros	count_zeros
a2	countones	count_ones
b	count_lines	countlines

---

From time to time people mention similar preferences.
Let's collect the suggestions. I'll copy them into this table.

---

moved from discourse

[imciner2]

As long as we are listing index-related ones: diagindex instead of diagind (or even the full word diagonalindex, but that might be making it too long).

[jakobnissen]

There was also some discussion about "position" being exported for a fairly obscure use case. Also, nextind should be nextindex. And also see #35285

[nickrobinson251]

Perhaps names could also be renamed, since it is such a generic word for quite a specific (and i believe rarely used) function. Possible more verbose option: namesfrom

[musm]

Totally agree on the index changes, it's really weird that we have firstindex, lastindex , but at the same time have prevind,nextind, thisin

[bramtayl]

Any sp... function is confusing. Maybe zeroes(SparseArray, m, n) instead of spzeroes(m, n)? Not sure if there's an issue open for that already

[oscardssmith]

I think the problem with this was that it's ambiguous with zeros(Int...) where the type is the eltype.

[bramtayl]

Oh, hmm, well, maybe a SparseElement dummy type then? There must be a nicer syntax then sp

[musm]

We have exported the methods: count_ones, count_zeros and countlines. Change count_ones -> countones and count_zeros -> countzeros, for symmetry. (Either this or countlines -> count_lines).

[JeffreySarnoff]

mentioned on slack, as a "spelling choice" VarArg rather than Vararg.

[musm]

Fixed up the recommendation:

Either:
count_ones change to countones
count_zeros change to countzeros
(matching countlines )

or
countlines to count_lines
(matching count_ones,countzeros )

[JeffreySarnoff]

see revised organization at top

[nickrobinson251]

xref #40466