Skip to content

Rename join to stringjoin or joinstring #37861

@iamed2

Description

@iamed2

On Slack I said:

join is occasionally frustrating because Base defines join for 1 to 3 Any args, so it's hard to extend without giving the user some confusion, and it's a common operation for a varying number of arguments (e.g., join N tables a la SQL)

I think join is not specific enough of a name to describe the operation implemented generically in Base

And @StefanKarpinski suggested opening an issue.

Another issue with join is that since it's extremely generic, it actually does apply to almost every type. So it's conceivable that you might want to join some databases but also separately stringjoin them for printing or something.

A somewhat-related discussion was had here: #26617

Metadata

Metadata

Assignees

No one assigned

    Labels

    breakingThis change will break codedeprecationThis change introduces or involves a deprecationstrings"Strings!"

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions