Refactor GC stats structs and names #50772
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbaraldi
changed the title
So increase the amount for 32 bit and tests
gbaraldi
force-pushed
the
accounting-refactor
branch
from
3e19377 to
859c5b4
Compare
JeffBezanson
reviewed
Aug 3, 2023
| size_t localbytes = jl_atomic_load_relaxed(&ptls->gc_num.allocd) + gc_num.interval; | ||
| jl_atomic_store_relaxed(&ptls->gc_num.allocd, -(int64_t)gc_num.interval); | ||
| static_assert(sizeof(_Atomic(uint64_t)) == sizeof(gc_num.deferred_alloc), ""); | ||
| jl_atomic_fetch_add((_Atomic(uint64_t)*)&gc_num.deferred_alloc, localbytes); |
There was a problem hiding this comment.
Are we sure we don't need anything like this anymore? When gc is disabled, we will start hitting a point where jl_gc_collect is called and jl_gc_disable_counter is atomically loaded on every allocation. Is that ok?
There was a problem hiding this comment.
So this is one of the things I'm not super sure. One thing that we could do here is to set the next collection to a very high value so we don't try to enter it at all. And then forcibly run a gc when we reanable it?
There was a problem hiding this comment.
The other is to update it with a simple default algorithm so that it does trigger but not so often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #50682