Skip to content

Add the PSD cone #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2017
Merged

Add the PSD cone #194

merged 1 commit into from
Jun 24, 2017

Conversation

blegat
Copy link
Member

@blegat blegat commented Jun 20, 2017

Scaled PSD cones are used by Mosek and SCS.
Unscaled PSD cones are used by SDPA, CSDP and DSDP.

#PositiveSemidefiniteCone

"""
PositiveSemidefiniteCone{Scaled}(n)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to have two separate cones for scaled and unscaled.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the names then :-P UnscaledPositiveSemidefiniteCone and ScaledPositiveSemidefiniteCone ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling in @chriscoey

@mlubin
Copy link
Member

mlubin commented Jun 21, 2017

I would vote for the "scaled" PSD cone to get the name PositiveSemidefiniteCone and the "unscaled" cone to get the longer name, like the LowerTrianglePositiveSemidefiniteCone, because it's really the lower triangle of entries in the cone. The scaled PSD cone makes much more sense to me and can be handled uniformly with other vector-based cones with regards to duality. The unscaled cone always needs to be a special case.

Edit: maybe VectorPositiveSemidefiniteCone and LowerTrianglePositiveSemidefiniteCone?

@blegat
Copy link
Member Author

blegat commented Jun 21, 2017

I like your idea. Why not TrianglePositiveSemidefiniteCone ? It does not matter whether it is upper or lower triangular.
In JuMP we will keep PSDCone for @constraint m X in PSDCone() and we will use TrianglePositiveSemidefiniteCone in conicdata ?

@mlubin
Copy link
Member

mlubin commented Jun 21, 2017

So VectorPositiveSemidefiniteCone and TrianglePositiveSemidefiniteCone?

@mlubin
Copy link
Member

mlubin commented Jun 22, 2017

@chriscoey and I have agreed on PositiveSemidefiniteConeScaled and PositiveSemidefiniteConeTriangle. What do you think?

@blegat blegat force-pushed the psd branch 2 times, most recently from be5d3d3 to 78cf5c7 Compare June 23, 2017 22:34
@blegat
Copy link
Member Author

blegat commented Jun 23, 2017

I like the names ! I have updated the PR :)

@mlubin mlubin merged commit c6f3838 into break_everything Jun 24, 2017
@mlubin mlubin deleted the psd branch June 24, 2017 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants