Skip to content

Upgrade to RegistryTools v2, and require at least RegistryTools 2.1.0 #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

DilumAluthge
Copy link
Member

Reverts #1268 (which reverted #1267)

@DilumAluthge DilumAluthge marked this pull request as ready for review March 13, 2023 00:27
@giordano
Copy link
Member

I mean, I reverted #1267 because it was broken. Unless you fix the breaking changes, this PR is not going to be accepted in the present form.

To make it crystal clear, we don't test registration at all, so don't expect to be able to catch errors that way. Of course, unless you volunteer to set up a mock registry for testing, which would be much welcome).

@DilumAluthge
Copy link
Member Author

d9f2fbf fixes the breaking changes. AFAICT that's the only place where RegistryTools is used.

Yeah, I don't know how to write a test for this, short of setting up a test registry, etc, like we do for RegistryCI.

@DilumAluthge
Copy link
Member Author

Bump @giordano @staticfloat

The second commit here should fix the breaking changes. Obviously I have no way of testing that. The commit is based on my reading of the RegistryTools source code, as well as the comment in the RegistryTools README about upgrading to the latest RegistryTools release.

@staticfloat
Copy link
Member

We tested this live on the #ci-dev call, and it successfully opened a PR to General: JuliaRegistries/General#80444

I believe this should be good to go.

Copy link
Member

@staticfloat staticfloat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Julia v1.7

@DilumAluthge DilumAluthge force-pushed the revert-1268-revert-1267-dpa/jlbuild branch from d9f2fbf to 335ed32 Compare March 27, 2023 19:09
@DilumAluthge DilumAluthge merged commit d972ad8 into master Mar 29, 2023
@DilumAluthge DilumAluthge deleted the revert-1268-revert-1267-dpa/jlbuild branch March 29, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants