Make pkg-config files relocatable post-installation #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests please, for example like in #1105 |
giordano
reviewed
Oct 24, 2024
giordano
reviewed
Oct 24, 2024
albinahlback
force-pushed
the
relocatable_pkgconfig
branch
from
b9a9965 to
f7eadaf
Compare
albinahlback
force-pushed
the
relocatable_pkgconfig
branch
from
f7eadaf to
043ed45
Compare
|
I don't know how to finalize the test, this will not pass. I would appreciate some help here. |
|
Timeout looks unrelated, as it passes the added tests: https://dev.azure.com/JuliaPackaging/BinaryBuilder.jl/_build/results?buildId=24640&view=logs&j=54759826-d195-5ca2-1571-21806663cd36&t=9eb882d6-5a34-5e37-1506-d0b4bf16214f&l=2534 |
giordano
reviewed
Nov 6, 2024
| @test "lib/pkgconfig/libfoo.pc" in contents | ||
| libfoo_pc = read(joinpath(testdir, "lib/pkgconfig/libfoo.pc"), String) | ||
| @test contains(libfoo_pc, "prefix=\${pcfiledir}") | ||
| @test !contains(libfoo_pc, "/workplace/destdir") |
Co-authored-by: Mosè Giordano <[email protected]>
|
Thanks for completing this! |
jmert
added a commit
to jmert/Yggdrasil
that referenced
this pull request
Nov 24, 2024
Following JuliaPackaging/BinaryBuilder.jl#1346 and the rebuild of Expat_jll (JuliaPackaging#9791), the workaround for pkgconfig `.pc` files containing the build `prefix` is no longer necessary. (Is there a way to actually add the compat constraint to `HostBuildDepencency`s?)
jmert
added a commit
to jmert/Yggdrasil
that referenced
this pull request
Nov 24, 2024
Following JuliaPackaging/BinaryBuilder.jl#1346 and the rebuild of Expat_jll (JuliaPackaging#9791), the workaround for pkgconfig `.pc` files containing the build `prefix` is no longer necessary. (Is there a way to actually add the compat constraint to `HostBuildDepencency`s?)
jmert
added a commit
to jmert/Yggdrasil
that referenced
this pull request
Dec 2, 2024
Following JuliaPackaging/BinaryBuilder.jl#1346 and the rebuild of Expat_jll (JuliaPackaging#9791), the workaround for pkgconfig `.pc` files containing the build `prefix` is no longer necessary. (Is there a way to actually add the compat constraint to `HostBuildDepencency`s?)
|
Apparently there are some packages which set % grep -r 'exec_prefix=/workspace/destdir' ~/.julia/artifacts --include='*.pc' | wc -l
20
% grep -r 'exec_prefix=${prefix}' ~/.julia/artifacts --include='*.pc' | wc -l
222I guess we should do the same for |
jmert
added a commit
to jmert/Yggdrasil
that referenced
this pull request
Jan 13, 2025
Following JuliaPackaging/BinaryBuilder.jl#1346 and the rebuild of Expat_jll (JuliaPackaging#9791), the workaround for pkgconfig `.pc` files containing the build `prefix` is no longer necessary. (Is there a way to actually add the compat constraint to `HostBuildDepencency`s?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1338, but I haven't tested this.
Ping @giordano.