Add bootstrap artifacts for LLVM 14, 15 and 17. #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Anything else I need to do?
If we don't need to touch anything in src/Runner.jl or similar to adjust the compiler wrappers then that's it, yes, thanks!
for some reason
--deploydidn't pick up mydeved BinaryBuilderBase.jl.
Uhm, that's weird, this is where the script picks the Artifacts.toml file: https://github.com/JuliaPackaging/Yggdrasil/blob/08aaaaf1af11396ae31ecf39d7e1501356f02c66/0_RootFS/common.jl#L61 It relies on pathof(BinaryBuilderBase) giving the right path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart of JuliaPackaging/Yggdrasil#9162.
@giordano Anything else I need to do? FWIW, I had to do the
Artifacts.tomlchanges manually, for some reason--deploydidn't pick up mydeved BinaryBuilderBase.jl.