Skip to content

CompatHelper: bump compat for Documenter to 1 for package docs, (keep existing compat)#1778

Merged
devmotion merged 6 commits into
masterfrom
compathelper/new_version/2023-09-16-00-05-54-816-00041392826
Jan 17, 2025
Merged

CompatHelper: bump compat for Documenter to 1 for package docs, (keep existing compat)#1778
devmotion merged 6 commits into
masterfrom
compathelper/new_version/2023-09-16-00-05-54-816-00041392826

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This pull request changes the compat entry for the Documenter package from 0.26, 0.27 to 0.26, 0.27, 1 for package docs.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@andreasnoack andreasnoack force-pushed the compathelper/new_version/2023-09-16-00-05-54-816-00041392826 branch from 97a74c2 to f66eb4f Compare September 16, 2023 00:06
@codecov-commenter

codecov-commenter commented Sep 16, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.19%. Comparing base (3b981a0) to head (0809e3e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1778   +/-   ##
=======================================
  Coverage   86.19%   86.19%           
=======================================
  Files         146      146           
  Lines        8768     8768           
=======================================
  Hits         7558     7558           
  Misses       1210     1210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penelopeysm

Copy link
Copy Markdown

(@devmotion, as you're the most active committer!) would it be possible to merge this please? Documenter v1.3 would generate a nice objects.inv file which lets us link to Distributions docs easily 🙂

@penelopeysm

Copy link
Copy Markdown

I checked it locally and this PR would probably also need a warnonly=true keyword argument to be added to makedocs(), as Documenter 1.x upgrades the warnings to errors by default.

@devmotion devmotion merged commit 1e6801d into master Jan 17, 2025
@devmotion devmotion deleted the compathelper/new_version/2023-09-16-00-05-54-816-00041392826 branch January 17, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants