ModuleDispatcher: dispatch on symbols (module name) instead of dispatching on modules
#127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atching on modules
|
We would need to revert #122 and add back Compat as a dependency. What versions of Julia do you need? |
|
The other issue with symbols is there could be clashes, because we check at every level of nesting. So I’d rather the more accurate version. But we could have a global IdDict and register stuff there or something like that. However for me part of the motivation was just dropping Compat.jl to remove another dep and simplifying by only supporting the LTS and newer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for older Julia versions was dropped recently in order to be able to dispatch on modules.
Instead of dispatching on modules, could we dispatch on symbols? This would allow us to restore support for older Julia versions/