Add support for the debug runtime in MSVC builds. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can force the linker to choose the debug runtime, which is necessary to override rusts libc, which by default wants to link to the release runtime, even in debug mode. With this patch CMake will override this behavior and use the debug runtime if appropriate. This is very important, as all parts of the program must agree on the runtime! As Qt in Debug mode uses the debug runtime in their DLLs, we may encounter undefined behavior otherwise.
LeonMatthesKDAB
added a commit
to LeonMatthesKDAB/cxx-qt
that referenced
this pull request
Apr 10, 2025
Once KDAB/cxx-qt-cmake#12 is merged, this should no longer be necessary. Closes KDAB#1234
LeonMatthesKDAB
added a commit
to LeonMatthesKDAB/cxx-qt
that referenced
this pull request
Apr 10, 2025
Once KDAB/cxx-qt-cmake#12 is merged, this should no longer be necessary. Closes KDAB#1234
LeonMatthesKDAB
added a commit
to LeonMatthesKDAB/cxx-qt
that referenced
this pull request
Apr 10, 2025
Once KDAB/cxx-qt-cmake#12 is merged, this should no longer be necessary. Closes KDAB#1234
ahayzen-kdab
added
the
backport-candidate
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can force the linker to choose the debug runtime, which is necessary
to override rusts libc, which by default wants to link to the release
runtime, even in debug mode.
With this patch CMake will override this behavior and use the debug
runtime if appropriate.
This is very important, as all parts of the program must agree on the runtime!
As Qt in Debug mode uses the debug runtime in their DLLs, we may
encounter undefined behavior otherwise.