Skip to content

Bump pkg-config-rs dependency to 0.3.26 #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bump pkg-config-rs dependency to 0.3.26 #335

wants to merge 1 commit into from

Conversation

LeonMatthesKDAB
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB added this to the 0.4 milestone Oct 26, 2022
@LeonMatthesKDAB LeonMatthesKDAB enabled auto-merge (rebase) October 26, 2022 08:10
ahayzen-kdab
ahayzen-kdab reviewed Oct 26, 2022
View reviewed changes
crates/qt-build-utils/Cargo.toml
@@ -14,7 +14,7 @@ repository = "https://github.com/KDAB/cxx-qt/"

[dependencies]
versions = "4.1.0"
pkg-config = { git = "https://github.com/Be-ing/pkg-config-rs.git", branch = "library_pub" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't work as it still requires vendoring of some private methods, but now that upstream has stabilised what we are going to use we can implement this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, alright, I thought the changes linked in the pkg-config-rs PR were enough for our purposes 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will work on decoupling the required code from pkg-config's structs this week.

Copy link
Contributor

@Be-ing Be-ing Oct 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context: I initially tried to use pkg-config, but Qt6 doesn't ship .pc files for static builds yet. Also, using pkg-config would require somehow getting the pkg-config executable on Windows. Instead, we're parsing the .prl files which are used by qmake.

@Be-ing
Copy link
Contributor

Be-ing commented Oct 26, 2022 •
edited
Loading

Superseded by #337

@Be-ing Be-ing closed this Oct 26, 2022
auto-merge was automatically disabled October 26, 2022 20:07

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing left review comments

@ahayzen-kdab ahayzen-kdab ahayzen-kdab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.

Remove any branches from cargo.toml's
3 participants
@LeonMatthesKDAB @Be-ing @ahayzen-kdab