Fix crash when attaching to a running process #699
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfaure-kdab
force-pushed
the
work/dfaure/fix-crash-futurewatcher
branch
from
2b5e06f to
5adeddd
Compare
If the user clicks the button while the process list is updating, the future is canceled, and calling result() on it is undefined behavior (and crashes). ASAN just says /usr/include/c++/14/bits/stl_tree.h:359:59: runtime error: member call on null pointer of type 'const struct _Rb_tree_node'
dfaure-kdab
force-pushed
the
work/dfaure/fix-crash-futurewatcher
branch
from
5adeddd to
07cbcec
Compare
milianw
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user clicks the button while the process list is updating, the future is canceled, and calling result() on it is undefined behavior (and crashes). ASAN just says
/usr/include/c++/14/bits/stl_tree.h:359:59: runtime error: member call on null pointer of type 'const struct _Rb_tree_node'