Skip to content

Handle openvpn requiring sudo and add CI tests #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Oct 16, 2024
Merged

Conversation

BeethovenKodar
Copy link
Collaborator

@BeethovenKodar BeethovenKodar commented Sep 20, 2024

Closes #4.

@BeethovenKodar BeethovenKodar self-assigned this Sep 20, 2024
@BeethovenKodar BeethovenKodar marked this pull request as draft September 20, 2024 19:46
@BeethovenKodar BeethovenKodar linked an issue Sep 20, 2024 that may be closed by this pull request
@BeethovenKodar BeethovenKodar marked this pull request as ready for review September 24, 2024 16:09
@BeethovenKodar
Copy link
Collaborator Author

I added CI tests for both macOS and Ubuntu (the ones that used to run locally only before) and sudo stuff works cleanly now. Though I'm not sure how to run the lint check, it seems stuck.

@BeethovenKodar BeethovenKodar changed the title Support to run module without explicit sudo python3 ... Handle openvpn requiring sudo and add CI tests Sep 26, 2024
@BeethovenKodar
Copy link
Collaborator Author

@bekelley @nkakouros Why is the lint not working just now? https://github.com/KTH-SSAS/python-openvpn-client/actions/runs/11109014995. Also any of you approve this so this is auto-merged when the checks pass.

@bekelley
Copy link
Collaborator

bekelley commented Oct 7, 2024

hmm, i can't figure out why the linter isn't working here.

I had thought maybe it was something changing in Action permissions/access token API, but I just tested from a branch on the twmn repo and it works there.

I'm not sure what has change locally to this repo..

@BeethovenKodar
Copy link
Collaborator Author

BeethovenKodar commented Oct 8, 2024

I'm thinking that this repo has to be added/configured in the settings page for twmn-ci. But I'm not very well-versed with these types of settings.

@BeethovenKodar
Copy link
Collaborator Author

@bekelley I'm pretty sure now after reading some documentation that it can't find lint.yml since this repo is public and twmn-ci is private and reusing the linting workflow here would disclose the details of the private lint.yml. I could copy the original workflow here for the time being, what do you think? Or, we could skip linting and ensure it's done locally instead, or possibly make the twmn-ci repo public although I don't think this is a great solution.

Also, this PR is ready for merging logic-wise.

@BeethovenKodar
Copy link
Collaborator Author

image

@BeethovenKodar
Copy link
Collaborator Author

@nkakouros @bekelley ?

@bekelley bekelley merged commit 3e2c1d9 into master Oct 16, 2024
2 checks passed
@bekelley bekelley deleted the sudo_support branch October 16, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sudo openvpn makes the process not exit properly
2 participants