-
Notifications
You must be signed in to change notification settings - Fork 5
Handle openvpn requiring sudo and add CI tests #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I added CI tests for both macOS and Ubuntu (the ones that used to run locally only before) and sudo stuff works cleanly now. Though I'm not sure how to run the lint check, it seems stuck. |
sudo python3 ...
@bekelley @nkakouros Why is the lint not working just now? https://github.com/KTH-SSAS/python-openvpn-client/actions/runs/11109014995. Also any of you approve this so this is auto-merged when the checks pass. |
hmm, i can't figure out why the linter isn't working here. I had thought maybe it was something changing in Action permissions/access token API, but I just tested from a branch on the twmn repo and it works there. I'm not sure what has change locally to this repo.. |
I'm thinking that this repo has to be added/configured in the settings page for twmn-ci. But I'm not very well-versed with these types of settings. |
@bekelley I'm pretty sure now after reading some documentation that it can't find Also, this PR is ready for merging logic-wise. |
Closes #4.