V17/rte block import fix#850
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes critical issues with rich text block migration from Umbraco v13 to v17rc, specifically addressing two problems: the internal block format not loading correctly when there are no existing values, and the Layout element not being imported due to the old "Umbraco.TinyMCE" value not deserializing properly.
Key changes:
- Added migration logic to convert obsolete block data structures (RawPropertyValues to Values, Udi to Key)
- Implemented a workaround to replace "Umbraco.TinyMCE" editor alias with the current alias during import
- Updated JSON converter ordering to process Udi converters before Object/BlockValue converters
- Updated Umbraco CMS dependencies from 17.0.0-rc1 to 17.0.0-rc2
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| uSync.Core/Mapping/SyncBlockMapperBase.cs | Adds MigrateBlock and MigrateBlockRawValues methods to handle migration of obsolete block data structures from v13 |
| uSync.Core/Mapping/Mappers/RTEMappers/RTEBlockDataContentMigrator.cs | Implements string replacement workaround for "Umbraco.TinyMCE" to current editor alias to fix deserialization |
| uSync.Core/Extensions/JsonTextExtensions.cs | Reorders JSON converters to process Udi converters before Object and BlockValue converters |
| uSync.Core/uSync.Core.csproj | Updates Umbraco CMS package references from 17.0.0-rc1 to 17.0.0-rc2 |
| uSync.Tests/uSync.Tests.csproj | Updates Microsoft.NET.Test.Sdk from 18.0.0 to 18.0.1 and Umbraco test packages to 17.0.0-rc2 |
| uSync.SchemaGenerator/uSync.SchemaGenerator.csproj | Updates NJsonSchema package from 11.5.1 to 11.5.2 |
| uSync.Community.DataTypeSerializers/uSync.Community.DataTypeSerializers.csproj | Updates Umbraco CMS package references to 17.0.0-rc2 |
| uSync.Backoffice.Management.Api/uSync.Backoffice.Management.Api.csproj | Updates Umbraco.Cms.Api.Management to 17.0.0-rc2 |
| uSync.AutoTemplates/uSync.AutoTemplates.csproj | Updates Umbraco.Cms.Core to 17.0.0-rc2 |
| uSync.Backoffice.Management.Client/usync-assets/package.json | Updates @umbraco-cms/backoffice from 17.0.0-rc1 to 17.0.0-rc2 |
| Various packages.lock.json files | Updates transitive dependencies to match new package versions |
| uSync.Tests/appsettings-schema.Umbraco.Cms.json | Adds new TemporaryFileUploadLocation configuration schema property |
Files not reviewed (1)
- uSync.Backoffice.Management.Client/usync-assets/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tor.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue (#847) of rich text blocks not migrating correctly from v13 sites into v17rc