Skip to content

V17/rte block import fix#850

Merged
KevinJump merged 5 commits into
v17/mainfrom
v17/rte-block-import-fix
Nov 13, 2025
Merged

V17/rte block import fix#850
KevinJump merged 5 commits into
v17/mainfrom
v17/rte-block-import-fix

Conversation

@KevinJump

Copy link
Copy Markdown
Owner

Fixes issue (#847) of rich text blocks not migrating correctly from v13 sites into v17rc

  • The internal block format was not loading correctly when there are no existing values (not sure if this is also true of core?).
  • The Layout element was not being imported because the old value "Umbraco.TinyMCE" does not get loaded when the serializer dieselizes the value (again not sure what happens in Umbraco.Core here, it also needs to do this).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes critical issues with rich text block migration from Umbraco v13 to v17rc, specifically addressing two problems: the internal block format not loading correctly when there are no existing values, and the Layout element not being imported due to the old "Umbraco.TinyMCE" value not deserializing properly.

Key changes:

  • Added migration logic to convert obsolete block data structures (RawPropertyValues to Values, Udi to Key)
  • Implemented a workaround to replace "Umbraco.TinyMCE" editor alias with the current alias during import
  • Updated JSON converter ordering to process Udi converters before Object/BlockValue converters
  • Updated Umbraco CMS dependencies from 17.0.0-rc1 to 17.0.0-rc2

Reviewed Changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
uSync.Core/Mapping/SyncBlockMapperBase.cs Adds MigrateBlock and MigrateBlockRawValues methods to handle migration of obsolete block data structures from v13
uSync.Core/Mapping/Mappers/RTEMappers/RTEBlockDataContentMigrator.cs Implements string replacement workaround for "Umbraco.TinyMCE" to current editor alias to fix deserialization
uSync.Core/Extensions/JsonTextExtensions.cs Reorders JSON converters to process Udi converters before Object and BlockValue converters
uSync.Core/uSync.Core.csproj Updates Umbraco CMS package references from 17.0.0-rc1 to 17.0.0-rc2
uSync.Tests/uSync.Tests.csproj Updates Microsoft.NET.Test.Sdk from 18.0.0 to 18.0.1 and Umbraco test packages to 17.0.0-rc2
uSync.SchemaGenerator/uSync.SchemaGenerator.csproj Updates NJsonSchema package from 11.5.1 to 11.5.2
uSync.Community.DataTypeSerializers/uSync.Community.DataTypeSerializers.csproj Updates Umbraco CMS package references to 17.0.0-rc2
uSync.Backoffice.Management.Api/uSync.Backoffice.Management.Api.csproj Updates Umbraco.Cms.Api.Management to 17.0.0-rc2
uSync.AutoTemplates/uSync.AutoTemplates.csproj Updates Umbraco.Cms.Core to 17.0.0-rc2
uSync.Backoffice.Management.Client/usync-assets/package.json Updates @umbraco-cms/backoffice from 17.0.0-rc1 to 17.0.0-rc2
Various packages.lock.json files Updates transitive dependencies to match new package versions
uSync.Tests/appsettings-schema.Umbraco.Cms.json Adds new TemporaryFileUploadLocation configuration schema property
Files not reviewed (1)
  • uSync.Backoffice.Management.Client/usync-assets/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread uSync.Core/Mapping/SyncBlockMapperBase.cs
Comment thread uSync.Core/Mapping/Mappers/RTEMappers/RTEBlockDataContentMigrator.cs Outdated
…tor.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@KevinJump KevinJump merged commit 4698be3 into v17/main Nov 13, 2025
3 checks passed
@KevinJump KevinJump deleted the v17/rte-block-import-fix branch November 13, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants