Allow StyleSheetServer to be minified out in client-only bundles, and StyleSheetTestUtils to be minified out in production#305
Merged
Conversation
These should never be used in production, so let's write it in a way that it can be minified out to further reduce bundle sizes. Not a huge impact, but might as well squeeze out a few more bytes.
Webpack can be configured to minify out this code when building bundles
that are client-only. This can be accomplished via the DefinePlugin:
```
new webpack.DefinePlugin({
"typeof window": JSON.stringify("object")
})
```
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow StyleSheetServer to be minified out in client-only bundles
Webpack can be configured to minify out this code when building bundles
that are client-only. This can be accomplished via the DefinePlugin:
Allow StyleSheetTestUtils to be minified out in production
These should never be used in production, so let's write it in a way
that it can be minified out to further reduce bundle sizes. Not a huge
impact, but might as well squeeze out a few more bytes.