Skip to content

fix(no-important): Fixes #311 Adds minify and flushToStyleTag to no-important#316

Merged
lencioni merged 1 commit into
Khan:masterfrom
dmiller9911:GH-311-no-important-exports
Mar 30, 2018
Merged

fix(no-important): Fixes #311 Adds minify and flushToStyleTag to no-important#316
lencioni merged 1 commit into
Khan:masterfrom
dmiller9911:GH-311-no-important-exports

Conversation

@dmiller9911
Copy link
Copy Markdown
Contributor

Added missing exports from no-important. Added a test to verify that the exports for each package
match to avoid this in the future. Updated chai to use a new assertion.

Fixes: #311

…no-important

Added missing exports from no-important.  Added a test to verify that the exports for each package
match to avoid this in the future.  Updated chai to use a new assertion.
Copy link
Copy Markdown
Collaborator

@lencioni lencioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@lencioni lencioni merged commit 3395c2b into Khan:master Mar 30, 2018
@Kerumen
Copy link
Copy Markdown

Kerumen commented Apr 9, 2018

@lencioni Can you release this on npm please?

@lencioni
Copy link
Copy Markdown
Collaborator

I'm traveling right now, so it might be tricky. Perhaps @xymostech can publish a patch release?

@lencioni
Copy link
Copy Markdown
Collaborator

Alright, I managed to get this published! @Kerumen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants