Fix examples, fixes #366#367
Conversation
|
Hey @kevinbarabash, Thanks for the PR! Mind signing our Contributor License Agreement? When you've done so, go ahead and comment Yours truly, |
| "devDependencies": { | ||
| "@babel/cli": "^7.0.0", | ||
| "@babel/core": "^7.0.0", | ||
| "@babel/preset-flow": "^7.0.0", |
There was a problem hiding this comment.
Unrelated: I think we should consider switching to TypeScript
…ges to root .babelrc
|
@lencioni thanks for the review. I still have some work to do to get lint passing before I can merge. I'll figure it out in the morning. 🙂 |
| import React from 'react'; | ||
| import { StyleSheet, css } from '../../src/index.js'; | ||
| import * as React from 'react'; | ||
| import { StyleSheet, css } from '../../lib/index.js'; |
There was a problem hiding this comment.
The reason for importing ../../lib/index.js instead of ../../src/index.js is that @babel/register doesn't want to compile files from outside of its directory subtree.
| on_start: never | ||
|
|
||
| after_script: | ||
| - npm run build |
There was a problem hiding this comment.
The linter was catching references in examples/src/*.js to ../../lib/index.js as not existing. This should fix that.
BrianGenisio
left a comment
BrianGenisio
left a comment
There was a problem hiding this comment.
Wowza. Thanks Kevin! This is really great! I'll try to play with it this weekend. Kevin is my hero. Seriously.
4 participants
The dependencies in
examples/package.jsonwere quite out of date. I've upgraded them to be current.To test this change I followed the instructions in
examples/README.mdand then opened http://localhost:4114/ in a browser and saw: