[Backport to 15] Align translation of OpCooperativeMatrixLengthKHR to match the spec (#2964) (#2997)#3013
Closed
KanclerzPiotr wants to merge 3 commits intoKhronosGroup:llvm_release_150from
Closed
Conversation
…ion (KhronosGroup#2559) The updated SPV_INTEL_bindless_images spec can be seen in this PR: intel/llvm#13753
…ampledImage builtin name (KhronosGroup#2576) Similar as ConvertHandleToImageINTEL, ConvertHandleToSampledImageINTEL builtin may have the same argument type but different return types. So we need to add ret type as name suffix when translating to LLVM IR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPV_KHR_cooperative_matrixextension defines that the only argumentaccepted in this instruction is
Matrix Type <id>, not the pointer toan actual matrix.