Validate that OpDecorateId IDs are well-ordered #6227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gfxstrand
force-pushed
the
decorate-id-order
branch
from
6d85151 to
72ec3f6
Compare
alan-baker
requested changes
Jul 25, 2025
gfxstrand
force-pushed
the
decorate-id-order
branch
from
72ec3f6 to
42d1bf8
Compare
alan-baker
approved these changes
Jul 25, 2025
Contributor
|
Formatting needs fixed. Separately it appears that DXC is generating invalid SPIR-V for AMDX work graph code. That doesn't need fixed before this is merged, but FYI @s-perron. |
There were a handful of tests which were violating this so we'll fix them up at the same time.
auto-merge was automatically disabled
July 28, 2025 13:27
Head branch was pushed to by a user without write access
gfxstrand
force-pushed
the
decorate-id-order
branch
from
42d1bf8 to
7dd001e
Compare
Collaborator
|
Thanks Alan. I'll look into the DXC smoke test. |
s-perron
added a commit
to s-perron/DirectXShaderCompiler
that referenced
this pull request
Jul 28, 2025
The value that decorates another value, but be declared before the value it decorates. See KhronosGroup/SPIRV-Tools#6227.
s-perron
added a commit
to s-perron/DirectXShaderCompiler
that referenced
this pull request
Jul 29, 2025
The value that decorates another value, but be declared before the value it decorates. See KhronosGroup/SPIRV-Tools#6227.
s-perron
added a commit
to microsoft/DirectXShaderCompiler
that referenced
this pull request
Jul 29, 2025
The value that decorates another value must be declared before the value it decorates. See KhronosGroup/SPIRV-Tools#6227.
svenvh
pushed a commit
to KhronosGroup/SPIRV-LLVM-Translator
that referenced
this pull request
Aug 8, 2025
A recent spirv-val change requires that OpDecorateId IDs are well-ordered, which means that the decoration operand ID cannot be the same as the decoration target ID. See: KhronosGroup/SPIRV-Tools#6227 This leads to the failure: ``` error: line 6: Parameter <ID> '2[%uint_0]' must appear earlier in the binary than the target OpDecorateId %uint_0 UniformId %uint_0 ``` The fix is to use a different ID for the decoration operand and the decoration target.
jsji
pushed a commit
to intel/llvm
that referenced
this pull request
Sep 6, 2025
A recent spirv-val change requires that OpDecorateId IDs are well-ordered, which means that the decoration operand ID cannot be the same as the decoration target ID. See: KhronosGroup/SPIRV-Tools#6227 This leads to the failure: ``` error: line 6: Parameter <ID> '2[%uint_0]' must appear earlier in the binary than the target OpDecorateId %uint_0 UniformId %uint_0 ``` The fix is to use a different ID for the decoration operand and the decoration target. Original commit: KhronosGroup/SPIRV-LLVM-Translator@fc5873ee760c333
github-actions bot
pushed a commit
to KhronosGroup/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 14, 2025
A recent spirv-val change requires that OpDecorateId IDs are well-ordered, which means that the decoration operand ID cannot be the same as the decoration target ID. See: KhronosGroup/SPIRV-Tools#6227 This leads to the failure: ``` error: line 6: Parameter <ID> '2[%uint_0]' must appear earlier in the binary than the target OpDecorateId %uint_0 UniformId %uint_0 ``` The fix is to use a different ID for the decoration operand and the decoration target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.