Repository navigation
Conversation
interop_max_work_group_queries.cpp named sycl::khr::info::device::max_work_group_range without template arguments, but the sycl_khr_max_work_group_queries extension declares it as `template <int Dimensions> struct max_work_group_range`. The test therefore fails to compile, and since all khr_split_headers sources are linked into a single test_khr_split_headers executable, the whole category fails to build. Check completeness of max_work_group_range<1>, <2> and <3> instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Contributor
|
LGTM. Thanks a lot for taking the time to report and opening a PR @itlabs ! Now I'm curious how does the CTS even passed. My recollection is that we waited for Digging... ah protosycl doesn't implement Mystery solved. |
TApplencourt
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/extension/khr_split_headers/interop_max_work_group_queries.cpp(added in #1205) usessycl::khr::info::device::max_work_group_rangewithout template arguments. Thesycl_khr_max_work_group_queriesextension declares it astemplate <int Dimensions> struct max_work_group_range, so the test fails to compile:Because all
khr_split_headerssources are linked into onetest_khr_split_headersexecutable, this breaks the entire category.This PR checks
max_work_group_range<1>,<2>and<3>instead, consistent withtests/extension/khr_max_work_group_queries.Tested with DPC++ (
-DSYCL_CTS_ENABLE_KHR_TESTS=ON) on Intel Data Center GPU Max 1100: all 461 test cases pass.🤖 Generated with Claude Code