layers: Clean up QUEUE_STATE, FENCE_STATE and SEMAPHORE_STATE by jeremyg-lunarg · Pull Request #3284 · KhronosGroup/Vulkan-ValidationLayers

jeremyg-lunarg · 2021-09-14T21:24:51Z

No description provided.

ci-tester-lunarg · 2021-09-14T21:24:54Z

CI Vulkan-ValidationLayers build queued with queue ID 35563.

ci-tester-lunarg · 2021-09-14T21:26:03Z

CI Vulkan-ValidationLayers build # 4762 running.

ci-tester-lunarg · 2021-09-14T21:47:54Z

CI Vulkan-ValidationLayers build # 4762 failed.

ci-tester-lunarg · 2021-09-15T20:27:32Z

CI Vulkan-ValidationLayers build queued with queue ID 36217.

ci-tester-lunarg · 2021-09-15T20:30:55Z

CI Vulkan-ValidationLayers build # 4770 running.

ci-tester-lunarg · 2021-09-15T20:57:11Z

CI Vulkan-ValidationLayers build # 4770 failed.

ci-tester-lunarg · 2021-09-16T14:09:59Z

CI Vulkan-ValidationLayers build queued with queue ID 36494.

ci-tester-lunarg · 2021-09-16T14:10:57Z

CI Vulkan-ValidationLayers build # 4774 running.

ci-tester-lunarg · 2021-09-16T14:30:52Z

CI Vulkan-ValidationLayers build # 4774 failed.

ci-tester-lunarg · 2021-09-17T17:37:55Z

CI Vulkan-ValidationLayers build queued with queue ID 37081.

ci-tester-lunarg · 2021-09-17T17:53:20Z

CI Vulkan-ValidationLayers build # 4792 running.

ci-tester-lunarg · 2021-09-17T18:22:30Z

CI Vulkan-ValidationLayers build # 4792 passed.

ci-tester-lunarg · 2021-09-17T20:26:03Z

CI Vulkan-ValidationLayers build queued with queue ID 37184.

ci-tester-lunarg · 2021-09-17T20:37:52Z

CI Vulkan-ValidationLayers build # 4799 running.

ci-tester-lunarg · 2021-09-17T21:08:18Z

CI Vulkan-ValidationLayers build # 4799 passed.

ci-tester-lunarg · 2021-09-28T17:24:30Z

CI Vulkan-ValidationLayers build queued with queue ID 43086.

ci-tester-lunarg · 2021-09-28T18:03:28Z

CI Vulkan-ValidationLayers build # 4949 running.

ci-tester-lunarg · 2021-09-28T18:32:23Z

CI Vulkan-ValidationLayers build # 4949 passed.

ci-tester-lunarg · 2021-09-28T22:07:32Z

CI Vulkan-ValidationLayers build queued with queue ID 43333.

ci-tester-lunarg · 2021-09-28T22:10:52Z

CI Vulkan-ValidationLayers build # 4956 running.

ci-tester-lunarg · 2021-09-28T22:40:22Z

CI Vulkan-ValidationLayers build # 4956 passed.

ci-tester-lunarg · 2021-09-30T17:11:03Z

CI Vulkan-ValidationLayers build queued with queue ID 44481.

ci-tester-lunarg · 2021-09-30T17:47:03Z

CI Vulkan-ValidationLayers build # 4994 running.

ci-tester-lunarg · 2021-09-30T17:51:25Z

CI Vulkan-ValidationLayers build queued with queue ID 44508.

ci-tester-lunarg · 2021-09-30T18:16:58Z

CI Vulkan-ValidationLayers build # 4995 running.

ci-tester-lunarg · 2021-09-30T18:47:07Z

CI Vulkan-ValidationLayers build # 4995 failed.

ci-tester-lunarg · 2021-09-30T20:38:28Z

CI Vulkan-ValidationLayers build queued with queue ID 44631.

ci-tester-lunarg · 2021-09-30T21:17:36Z

CI Vulkan-ValidationLayers build # 5002 running.

ci-tester-lunarg · 2021-09-30T21:57:17Z

CI Vulkan-ValidationLayers build # 5002 passed.

ci-tester-lunarg · 2021-10-15T15:25:45Z

CI Vulkan-ValidationLayers build queued with queue ID 1449.

ci-tester-lunarg · 2021-10-15T16:32:16Z

CI Vulkan-ValidationLayers build # 5208 running.

ci-tester-lunarg · 2021-10-15T16:59:41Z

CI Vulkan-ValidationLayers build # 5208 passed.

jeremyg-lunarg · 2021-10-15T18:58:03Z

This PR changes error count for a single trace in the vvltraces run:

ERROR: doometernal: differences between reference errors and generated errors:
* VUID-vkDestroySemaphore-semaphore-01137: 1: 2

Running the same trace locally, I don't get ANY of these errors. ¯_(ツ)_/¯

ncesario-lunarg · 2021-10-15T19:13:52Z

Running the same trace locally, I don't get ANY of these errors.

Device-dependent?

ncesario-lunarg

More nice cleanup!

jeremyg-lunarg · 2021-10-15T19:22:50Z

Running the same trace locally, I don't get ANY of these errors.

Device-dependent?

Or driver version. Trace is from RTX2060 and I have RTX2080, and most certainly a newer driver.

Move these ValidationStateTracker methods to queue_state.cpp. This is a prepatory change before making them methods of other state objects.

Replace the 'signaler' members with an actual struct so that we can use better field names than first and second.

Move methods for processing Queue submissions to be part of QUEUE_STATE or other state objects. Reorganize submission to have most of the logic in QUEUE_STATE::Submit and store shared pointers to the objects in the submission rather than repeatedly looking up handles.

ci-tester-lunarg · 2021-10-21T14:56:33Z

CI Vulkan-ValidationLayers build queued with queue ID 4657.

ci-tester-lunarg · 2021-10-21T15:00:50Z

CI Vulkan-ValidationLayers build # 5290 running.

ci-tester-lunarg · 2021-10-21T15:24:14Z

CI Vulkan-ValidationLayers build # 5290 passed.

jeremyg-lunarg force-pushed the jeremyg-queue-state branch from fad2afd to f1b0fd0 Compare September 15, 2021 20:27

filnet reviewed Sep 16, 2021

View reviewed changes

Comment thread layers/CMakeLists.txt Outdated

jeremyg-lunarg force-pushed the jeremyg-queue-state branch from f1b0fd0 to 7886b4a Compare September 16, 2021 14:09

jeremyg-lunarg marked this pull request as draft September 16, 2021 15:20

jeremyg-lunarg force-pushed the jeremyg-queue-state branch from 7886b4a to f4beb9a Compare September 17, 2021 17:37

jeremyg-lunarg force-pushed the jeremyg-queue-state branch from f4beb9a to 475959a Compare September 17, 2021 20:26

jeremyg-lunarg force-pushed the jeremyg-queue-state branch from 475959a to 8c6049a Compare September 28, 2021 17:24

jeremyg-lunarg force-pushed the jeremyg-queue-state branch from 8c6049a to e17fed9 Compare September 28, 2021 22:07

jeremyg-lunarg force-pushed the jeremyg-queue-state branch from e17fed9 to 9d7baea Compare September 30, 2021 17:11

jeremyg-lunarg force-pushed the jeremyg-queue-state branch from 6badd8a to 2ccfe62 Compare September 30, 2021 20:38

jeremyg-lunarg force-pushed the jeremyg-queue-state branch from 2ccfe62 to 32f36e6 Compare October 15, 2021 15:25

jeremyg-lunarg marked this pull request as ready for review October 15, 2021 18:54

jeremyg-lunarg requested review from jzulauf-lunarg, ncesario-lunarg and ziga-lunarg October 15, 2021 18:54

ncesario-lunarg approved these changes Oct 15, 2021

View reviewed changes

jeremyg-lunarg added 3 commits October 21, 2021 08:41

layers: Move Queue, Semaphore and Fence methods to a new file

0c938c7

Move these ValidationStateTracker methods to queue_state.cpp. This is a prepatory change before making them methods of other state objects.

layers: Remove std::pair<> from Fence and Semaphore state

ddfc2d6

Replace the 'signaler' members with an actual struct so that we can use better field names than first and second.

jeremyg-lunarg force-pushed the jeremyg-queue-state branch from 32f36e6 to 169e278 Compare October 21, 2021 14:56

jeremyg-lunarg merged commit 5764298 into KhronosGroup:master Oct 21, 2021

jeremyg-lunarg deleted the jeremyg-queue-state branch October 21, 2021 16:03

Conversation

jeremyg-lunarg commented Sep 14, 2021

Uh oh!

ci-tester-lunarg commented Sep 14, 2021

Uh oh!

ci-tester-lunarg commented Sep 14, 2021

Uh oh!

ci-tester-lunarg commented Sep 14, 2021

Uh oh!

ci-tester-lunarg commented Sep 15, 2021

Uh oh!

ci-tester-lunarg commented Sep 15, 2021

Uh oh!

ci-tester-lunarg commented Sep 15, 2021

Uh oh!

Uh oh!

ci-tester-lunarg commented Sep 16, 2021

Uh oh!

ci-tester-lunarg commented Sep 16, 2021

Uh oh!

ci-tester-lunarg commented Sep 16, 2021

Uh oh!

ci-tester-lunarg commented Sep 17, 2021

Uh oh!

ci-tester-lunarg commented Sep 17, 2021

Uh oh!

ci-tester-lunarg commented Sep 17, 2021

Uh oh!

ci-tester-lunarg commented Sep 17, 2021

Uh oh!

ci-tester-lunarg commented Sep 17, 2021

Uh oh!

ci-tester-lunarg commented Sep 17, 2021

Uh oh!

ci-tester-lunarg commented Sep 28, 2021

Uh oh!

ci-tester-lunarg commented Sep 28, 2021

Uh oh!

ci-tester-lunarg commented Sep 28, 2021

Uh oh!

ci-tester-lunarg commented Sep 28, 2021

Uh oh!

ci-tester-lunarg commented Sep 28, 2021

Uh oh!

ci-tester-lunarg commented Sep 28, 2021

Uh oh!

ci-tester-lunarg commented Sep 30, 2021

Uh oh!

ci-tester-lunarg commented Sep 30, 2021

Uh oh!

ci-tester-lunarg commented Sep 30, 2021

Uh oh!

ci-tester-lunarg commented Sep 30, 2021

Uh oh!

ci-tester-lunarg commented Sep 30, 2021

Uh oh!

ci-tester-lunarg commented Sep 30, 2021

Uh oh!

ci-tester-lunarg commented Sep 30, 2021

Uh oh!

ci-tester-lunarg commented Sep 30, 2021

Uh oh!

ci-tester-lunarg commented Oct 15, 2021

Uh oh!

ci-tester-lunarg commented Oct 15, 2021

Uh oh!

ci-tester-lunarg commented Oct 15, 2021

Uh oh!

jeremyg-lunarg commented Oct 15, 2021

Uh oh!

ncesario-lunarg commented Oct 15, 2021

Uh oh!

ncesario-lunarg left a comment

Choose a reason for hiding this comment

Uh oh!

jeremyg-lunarg commented Oct 15, 2021

Uh oh!

ci-tester-lunarg commented Oct 21, 2021

Uh oh!

ci-tester-lunarg commented Oct 21, 2021