layers: Remove excess state object lookups#3541
Merged
jeremyg-lunarg merged 1 commit intoNov 17, 2021
Merged
Conversation
Remove some places where we were doing unnecessary lookups of state objects from handles, when there is already a pointer to the state object available. None of these seem to have a measurable performance difference, but that might change once we move to fine grained locking.
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 1769. |
Collaborator
|
CI Vulkan-ValidationLayers build # 5523 running. |
Collaborator
|
CI Vulkan-ValidationLayers build # 5523 passed. |
jzulauf-lunarg
left a comment
jzulauf-lunarg
left a comment
Contributor
There was a problem hiding this comment.
These seem strangely familiar... LGTM2
Contributor
Author
Yes, with a couple of extras. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some places where we were doing unnecessary lookups of
state objects from handles, when there is already a pointer to the
state object available. None of these seem to have a measurable
performance difference, but that might change once we move to
fine grained locking.