upload more file types #616

tru-kilo · 2025-06-04T20:26:47Z

Context

Adding the ability to upload more file types specifically "xml", "json", "txt", "log", "md", "docx", "ipynb", "pdf".
Fixes #577

Screenshots

Screen.Recording.2025-06-05.at.9.22.48.PM.mov

How to Test

Import a file type that's been recently added and see if it is able to read and parse through the file!

changeset-bot · 2025-06-04T20:26:51Z

🦋 Changeset detected

Latest commit: c5094ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
kilo-code	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

hassoncs

Looks pretty good to me! I left a few comments / questions mostly around conflicts and possibly trying to share more of the image/file code (for size limits). I think my main comment overall is @kevinvandijk likes us to add //kilocode_change start/end markers in any roo code, so make sure to go though and add those in

.changeset/grumpy-bugs-behave.md

hassoncs · 2025-06-09T13:26:20Z

src/core/webview/webviewMessageHandler.ts

 		case "selectImages":
-			const images = await selectImages()
-			await provider.postMessageToWebview({ type: "selectedImages", images })
+			const { images, files } = await selectFiles()
+			await provider.postMessageToWebview({ type: "selectedImages", images, filePaths: files })


Hmm, should we have a separate message type for selectFiles? Just noticing the names matched before and now there's a disconnect, case selectImages calling selectFiles

This is how Cline does it but I'm down to change it!

Would be possible to keep Roo's selectImages, but then also add our own selectFiles below this that only deals with files?

hassoncs · 2025-06-09T13:26:54Z

src/core/webview/webviewMessageHandler.ts

@@ -1061,7 +1062,10 @@ export const webviewMessageHandler = async (provider: ClineProvider, message: We
 						supportPrompt.create("ENHANCE", { userInput: message.text }, customSupportPrompts),
 					)

-					await provider.postMessageToWebview({ type: "enhancedPrompt", text: enhancedPrompt })
+					await provider.postMessageToWebview({


revert if you can to avoid conflicts

src/extension/api.ts

src/integrations/misc/extract-text.ts

src/integrations/misc/process-files.ts

webview-ui/src/components/common/Thumbnails.tsx

webview-ui/src/components/chat/ChatTextArea.tsx

src/integrations/misc/process-files.ts

hassoncs

submitting our pair review comments

src/core/task/Task.ts

hassoncs · 2025-06-09T17:39:33Z

src/core/task/Task.ts

 		this.emit("taskAskResponded")
 		return result
 	}

-	async handleWebviewAskResponse(askResponse: ClineAskResponse, text?: string, images?: string[]) {
+	async handleWebviewAskResponse(askResponse: ClineAskResponse, text?: string, images?: string[], files?: string[]) {


filePaths maybe?

src/core/webview/webviewMessageHandler.ts

src/integrations/misc/extract-text.ts

src/package.json

hassoncs · 2025-06-09T17:50:51Z

webview-ui/src/components/chat/ChatView.tsx

@@ -430,26 +425,6 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro

 	useEffect(() => () => everVisibleMessagesTsRef.current.clear(), [])

-	useEffect(() => {


double check this– make sure it wasn't a merge conflict

webview-ui/src/components/chat/ChatView.tsx

hassoncs · 2025-06-09T18:00:30Z

webview-ui/src/components/common/Thumbnails.tsx

+									color: "var(--vscode-foreground)",
+								}}></span>
+							<span
+								style={{


maybe tailwind-ify :D

webview-ui/src/components/chat/TaskHeader.tsx

chrarnoldus · 2025-06-10T15:29:38Z

Isn't it a bit confusing we have "Import File" and "Add File" next to each other now?

tru-kilo · 2025-06-10T15:48:54Z

Isn't it a bit confusing we have "Import File" and "Add File" next to each other now?

Yeah I'm not sure what to do here, the Add File is like a file within the code, vs. Import is from outside and it works with both files and images

Co-authored-by: Christiaan Arnoldus <[email protected]>

hassoncs

Still a bunch of spots where we could be better with the kilocode_change comments. I'm sorry– I know they are annoying!

I think my main thought is this is going to be a slight-nightmare to merge with Roo... I wonder if we should open this PR against them to save ourselves difficulty down the line. @kevinvandijk might have thoughts, but I don't want to slow you down more

src/core/assistant-message/presentAssistantMessage.ts

src/core/prompts/responses.ts

hassoncs · 2025-06-10T19:24:48Z

src/core/task/Task.ts

@@ -88,6 +88,7 @@ import { parseMentions } from "../mentions" // kilocode_change
 import { parseKiloSlashCommands } from "../slash-commands/kilo" // kilocode_change
 import { GlobalFileNames } from "../../shared/globalFileNames" // kilocode_change
 import { ensureLocalKilorulesDirExists } from "../context/instructions/kilo-rules" // kilocode_change
+import { processFilesIntoText } from "../../integrations/misc/process-files"


this file needs a bunch of kilocode_change

hassoncs · 2025-06-10T19:26:43Z

src/core/webview/webviewMessageHandler.ts

 		case "selectImages":
-			const images = await selectImages()
-			await provider.postMessageToWebview({ type: "selectedImages", images })
+			const { images, files } = await selectFiles()
+			await provider.postMessageToWebview({ type: "selectedImages", images, filePaths: files })


Would be possible to keep Roo's selectImages, but then also add our own selectFiles below this that only deals with files?

src/integrations/misc/process-files.ts

webview-ui/src/components/chat/ChatView.tsx

chrarnoldus · 2025-06-10T19:39:52Z

Yeah I'm not sure what to do here, the Add File is like a file within the code, vs. Import is from outside and it works with both files and images

If we have to have both, I would rename "Add file" to "Reference file" and "Import" to "Upload". But tbh I don't understand why we need both, "Add file" would work with external files too if the UI allowed selecting them (or if you mention their paths manually).

hassoncs

Im still seeing missing //kilocode_changes and there still seems to be some code that was unintentionally changed in webview-ui/src/components/chat/ChatView.tsx. I'd recommend going into the full diff view of the PR and be very thorough with the // kilocode_changes. I didn't want to leave a bunch of comments, but there's still quite a few missing spots. Edit sorry, some of those changes were definitely intended! but maybe wrap them in useCallback

(the code in question)

const handleSuggestionClickInRow = useCallback(
		(answer: string, event?: React.MouseEvent) => {
			if (event?.shiftKey) {
				// Always append to existing text, don't overwrite
				setInputValue((currentValue) => {
					return currentValue !== "" ? `${currentValue} \n${answer}` : answer
				})
			} else {
				handleSendMessage(answer, [])
			}
		},
		[handleSendMessage, setInputValue], // setInputValue is stable, handleSendMessage depends on clineAsk
	)

	const handleBatchFileResponse = useCallback((response: { [key: string]: boolean }) => {
		// Handle batch file response, e.g., for file uploads
		vscode.postMessage({ type: "askResponse", askResponse: "objectResponse", text: JSON.stringify(response) })
	}, [])

hassoncs · 2025-06-10T21:23:18Z

webview-ui/src/components/chat/ChatView.tsx

+								text,
+								images,
+								files,
+							})
 							break
 						// kilocode_change start


maybe just move this up to include your changes? // kilocode_change start

hassoncs · 2025-06-10T21:24:24Z

webview-ui/src/components/chat/ChatView.tsx

+			console.error("Error selecting files and images:", error)
+		}
+	}, [selectedImages, selectedFiles])
+	// kilocode_change end


hassoncs · 2025-06-10T21:25:16Z

webview-ui/src/components/chat/ChatView.tsx

+					onToggleExpand={() => toggleRowExpansion(messageOrGroup.ts)}
+					lastModifiedMessage={modifiedMessages.at(-1)}
+					isLast={index === groupedMessages.length - 1}
 					onHeightChange={handleRowHeightChange}


Unintentional changes here?

hassoncs · 2025-06-10T21:30:53Z

webview-ui/src/components/chat/ChatView.tsx

+						if (event?.shiftKey) {
+							// Always append to existing text, don't overwrite
+							setInputValue((currentValue) => {
+								return currentValue !== "" ? `${currentValue} \n${answer}` : answer
+							})
+						} else {
+							handleSendMessage(answer, [], [])
+						}
+					}}


should this be a useCallback like the previous version?

tru-kilo marked this pull request as ready for review June 6, 2025 02:28

tru-kilo changed the title ~~Tru upload more file types~~ upload more file types Jun 6, 2025

tru-kilo requested review from kevinvandijk and hassoncs June 6, 2025 02:28

tru-kilo force-pushed the tru-upload-more-file-types branch from c0d3598 to 7eaeedd Compare June 6, 2025 16:22

hassoncs reviewed Jun 9, 2025

View reviewed changes

src/integrations/misc/process-files.ts Show resolved Hide resolved

tru-kilo added 12 commits June 9, 2025 13:40

save

7d169d6

save

91d13f8

save

3c05707

save

f110647

save

c267655

fix tests

c0a9000

fix tests again

67d4d54

used the function properly

690bfc5

clean up the code

6127b1c

changeset

71bab89

fix test

ec4a650

fix test

0739a52

tru-kilo force-pushed the tru-upload-more-file-types branch from 7eaeedd to 0739a52 Compare June 9, 2025 18:40

tru-kilo added 4 commits June 9, 2025 14:11

address comments

1ac1277

address comments

dd6c739

fix pnpm

32cb23c

i forgot to hit save

e5c615b

hassoncs reviewed Jun 9, 2025

View reviewed changes

address comments

38db8b3

tru-kilo requested a review from hassoncs June 10, 2025 04:57

address comment

c2358bb

tru-kilo requested a review from chrarnoldus June 10, 2025 15:04

tru-kilo requested a review from drakonen June 10, 2025 15:04

chrarnoldus reviewed Jun 10, 2025

View reviewed changes

webview-ui/src/components/chat/TaskHeader.tsx Outdated Show resolved Hide resolved

tru-kilo and others added 2 commits June 10, 2025 11:05

Update webview-ui/src/components/chat/TaskHeader.tsx

929c4fa

Co-authored-by: Christiaan Arnoldus <[email protected]>

fix types

dc35299

tru-kilo requested a review from chrarnoldus June 10, 2025 16:52

hassoncs reviewed Jun 10, 2025

View reviewed changes

address comments

6aabb41

tru-kilo requested a review from hassoncs June 10, 2025 20:18

hassoncs reviewed Jun 10, 2025

View reviewed changes

chrarnoldus self-assigned this Jun 13, 2025

Merge branch 'main' into tru-upload-more-file-types

c5094ab

chrarnoldus closed this Jun 16, 2025

		@@ -430,26 +425,6 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro

		useEffect(() => () => everVisibleMessagesTsRef.current.clear(), [])

		useEffect(() => {

upload more file types #616

upload more file types #616

Uh oh!

Conversation

tru-kilo commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Screenshots

How to Test

Uh oh!

changeset-bot bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

hassoncs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hassoncs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chrarnoldus commented Jun 10, 2025

Uh oh!

tru-kilo commented Jun 10, 2025

Uh oh!

hassoncs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chrarnoldus commented Jun 10, 2025

Uh oh!

hassoncs left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tru-kilo commented Jun 4, 2025 •

edited

Loading

changeset-bot bot commented Jun 4, 2025 •

edited

Loading

hassoncs left a comment •

edited

Loading