Skip to content

Add PHP 8.4 Compatibility #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Add PHP 8.4 Compatibility #104

merged 2 commits into from
Mar 28, 2025

Conversation

n7studios
Copy link
Contributor

Summary

Runs tests against PHP 8.4, adding compatibility to fix the Implicitly marking parameter $value as nullable is deprecated, the explicit nullable type must be used instead deprecated notice, by using the Union Type on null parameters.

Testing

Existing tests pass.

Checklist

@n7studios n7studios self-assigned this Mar 28, 2025
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team March 28, 2025 03:16
@n7studios n7studios marked this pull request as ready for review March 28, 2025 03:16
Copy link

@corydhmiller corydhmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@n7studios n7studios merged commit 5ac12bc into fix-tests Mar 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants