-
Notifications
You must be signed in to change notification settings - Fork 24
Fix get_subscriber_id()
by email performance
#31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2023
get_subscriber_id()
by email performance
noelherrick
approved these changes
Mar 6, 2023
Apply Coding Standards
Improve `get_resource()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calling
get_subscriber_id()
, includes theemail_address
as an argument, instead of attempting to fetch every single subscriber and then iterating through the array of subscribers to find a match.Fixes:
testGetResource
fails, due to code using a third party library that's reliant on the (not recommended)file_get_contents()
. A separate PR to fix the code will result in this test passing.Testing
testGetSubscriberID
: Tests that fetching a subscriber ID by email address works when a valid subscriber email address is suppliedtestGetSubscriberIDWithInvalidEmailAddress
: Tests that anInvalidArgumentException
is thrown when an invalid email address is suppliedtestGetSubscriberIDWithNotSubscribedEmailAddress
: Tests that fetching a subscriber ID by email address returns false when a valid email address is supplied, but is not a subscriberChecklist