Skip to content

Update add_subscriber_to_sequence() to support name, custom fields and tags #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

n7studios
Copy link
Contributor

Summary

Updates the add_subscriber_to_sequence() API function, to include support for first name, custom fields and tags, per https://developers.convertkit.com/#add-subscriber-to-a-sequence.

Adds tests to improve test coverage of new function arguments.

Testing

  • testAddSubscriberToSequenceWithFirstName: Test that adding a subscriber to a sequence with a first name specified works.
  • testAddSubscriberToSequenceWithCustomFields: Test that adding a subscriber to a sequence with a custom field works.
  • testAddSubscriberToSequenceWithTagID: Test that adding a subscriber to a sequence with a tag ID works.
  • testGetSequenceSubscriptionsWithDescSortOrder: Test that fetching a subscriber's sequences in descending order works.
  • testGetSequenceSubscriptionsWithInvalidSortOrder: Test that a ClientException is thrown when an fetching a subscriber's sequences with an invalid sort order.

Checklist

@n7studios n7studios added this to the 1.0.0 milestone Mar 10, 2023
@n7studios n7studios self-assigned this Mar 10, 2023
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team March 10, 2023 16:28
@n7studios n7studios marked this pull request as ready for review March 10, 2023 16:28
@n7studios n7studios merged commit 84e0fe6 into 1.0-beta Mar 13, 2023
@n7studios n7studios deleted the sequence-functions branch March 23, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants