Skip to content

Removes $resources and $markup class properties #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

n7studios
Copy link
Contributor

Summary

Removes code in the API class that stores the results of get_resources() and get_resource() functions into class properties.

This data isn't cached and doesn't persist beyond a single PHP request life cycle, so it's pointless.

If developers wish to cache the results of an API call (such as a list of forms or landing page HTML markup), they can do so within their application.

Testing

Existing tests pass.

Checklist

@n7studios n7studios added this to the 1.0.0 milestone Mar 17, 2023
@n7studios n7studios self-assigned this Mar 17, 2023
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team March 17, 2023 18:31
@n7studios n7studios marked this pull request as ready for review March 20, 2023 14:17
Copy link

@noelherrick noelherrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@n7studios n7studios merged commit 58d16dc into 1.0-beta Mar 20, 2023
@n7studios n7studios deleted the remove-storing-resources-in-class branch March 23, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants