Removes $resources
and $markup
class properties
#52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes code in the API class that stores the results of
get_resources()
andget_resource()
functions into class properties.This data isn't cached and doesn't persist beyond a single PHP request life cycle, so it's pointless.
If developers wish to cache the results of an API call (such as a list of forms or landing page HTML markup), they can do so within their application.
Testing
Existing tests pass.
Checklist