Add add_subscriber_to_form()
function with named arguments
#54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
add_subscriber_to_form()
API function, to include support for first name, custom fields and tags, per https://developers.convertkit.com/#add-subscriber-to-a-form.Outputs a PHP deprecated notice if using the existing
form_subscribe()
, function, as its second argument supports an array of options, whilstadd_subscriber_to_form()
provides the specific named arguments (form ID, email address, first name, custom fields), as we do for e.g.add_subscriber_to_sequence()
.Adds tests to improve test coverage of new function arguments.
Testing
testAddSubscriberToForm
: Test that adding a subscriber to a form workstestAddSubscriberToFormWithInvalidFormID
: Test that adding a subscriber to an invalid form ID throws aClientException
testAddSubscriberToFormWithInvalidEmailAddress
: Test that adding a subscriber to a form with an invalid email address throws aClientException
testAddSubscriberToFormWithFirstName
: Test that adding a subscriber to a form with a first name specified works.testAddSubscriberToFormWithCustomFields
: Test that adding a subscriber to a form with a custom field works.testAddSubscriberToFormWithTagID
: Test that adding a subscriber to a form with a tag ID works.Checklist